Programming help required (GDscript or C#)

[Rich-Allen1976]

Getting errors in this code.
 

Code: Select all

 
extends Area2D 

export -(int)-var-Speed
var velocity =Vector2 ()
var screensize = Vector2 (480, 720)
func get_input() :
velocity = vector2()
if Input.is_action_pressed ("ui_left") :
velocity.x-= 1
if input.is_action_pressed ("ui_right") :
velocity.x+= 1
if Input.is_action_pressed ("ui_up") :
velocity.y-= 1 
if Input.is_action_pressed ("ui_down") :
velocity.y+= 1
if velocity.length() > 0:
velocity velocity.normalized() * speed

Can anyone help me fix it?
 

[Beerkeg]

I've not written any GDscript or even heard of it, but this doesn't return any errors. Seems like some formatting issues, typos and indenting:

extends Area2D

export var Speed:int
var velocity = Vector2()
var screensize = Vector2 (480, 720)
func get_input():
velocity = Vector2()
if Input.is_action_pressed ("ui_left"):
velocity.x -= 1
if Input.is_action_pressed ("ui_right"):
velocity.x += 1
if Input.is_action_pressed ("ui_up"):
velocity.y -= 1
if Input.is_action_pressed ("ui_down"):
velocity.y += 1
if velocity.length() > 0:
velocity = velocity.normalized() * Speed

[Rich-Allen1976]

I've not written any GDscript or even heard of it, but this doesn't return any errors. Seems like some formatting issues, typos and indenting:

extends Area2D

export var Speed:int
var velocity = Vector2()
var screensize = Vector2 (480, 720)
func get_input():
velocity = Vector2()
if Input.is_action_pressed ("ui_left"):
velocity.x -= 1
if Input.is_action_pressed ("ui_right"):
velocity.x += 1
if Input.is_action_pressed ("ui_up"):
velocity.y -= 1
if Input.is_action_pressed ("ui_down"):
velocity.y += 1
if velocity.length() > 0:
velocity = velocity.normalized() * Speed

Thanks, I'll see if this works.
 

Code: Select all

 
extends Area2D

export var Speed:int
var velocity = Vector2()
var screensize = Vector2 (480, 720)
func get_input():
velocity = Vector2()
if Input.is_action_pressed ("ui_left"):
velocity.x -= 1
if Input.is_action_pressed ("ui_right"):
velocity.x += 1
if Input.is_action_pressed ("ui_up"):
velocity.y -= 1
if Input.is_action_pressed ("ui_down"):
velocity.y += 1
if velocity.length() > 0:
velocity = velocity.normalized() * Speed

Returns an error on the "if" after vector2()
 

[Beerkeg]

I've not written any GDscript or even heard of it, but this doesn't return any errors. Seems like some formatting issues, typos and indenting:

extends Area2D

export var Speed:int
var velocity = Vector2()
var screensize = Vector2 (480, 720)
func get_input():
velocity = Vector2()
if Input.is_action_pressed ("ui_left"):
velocity.x -= 1
if Input.is_action_pressed ("ui_right"):
velocity.x += 1
if Input.is_action_pressed ("ui_up"):
velocity.y -= 1
if Input.is_action_pressed ("ui_down"):
velocity.y += 1
if velocity.length() > 0:
velocity = velocity.normalized() * Speed

Thanks, I'll see if this works.

Code: Select all

 
extends Area2D

export var Speed:int
var velocity = Vector2()
var screensize = Vector2 (480, 720)
func get_input():
velocity = Vector2()
if Input.is_action_pressed ("ui_left"):
velocity.x -= 1
if Input.is_action_pressed ("ui_right"):
velocity.x += 1
if Input.is_action_pressed ("ui_up"):
velocity.y -= 1
if Input.is_action_pressed ("ui_down"):
velocity.y += 1
if velocity.length() > 0:
velocity = velocity.normalized() * Speed

Returns an error on the "if" after vector2()

Sorry about that, didn't realize the forum gets rid of the formatting :P
You need to indent your code so 1 tab before velocity = Vector2() and all the if statements and 2 tabs before the if returns. Like in this image (if the image uploads properly)

[Rich-Allen1976]

That's very helpful

I'll see if it works later.

Unfortunately the link doesn't work.

Well it does but I have to sign into the website to view the pic.

Would you be able to inbox me the code so I can copy/paste it into Godot?

[Beerkeg]

That's very helpful :)

I'll see if it works later.

Unfortunately the link doesn't work.

Well it does but I have to sign into the website to view the pic.

Would you be able to inbox me the code so I can copy/paste it into Godot?

Made a pastebin with it, it kept the formatting there

https://pastebin.com/U4rGBS8Y

[Rich-Allen1976]

That's very helpful

I'll see if it works later.

Unfortunately the link doesn't work.

Well it does but I have to sign into the website to view the pic.

Would you be able to inbox me the code so I can copy/paste it into Godot?

Made a pastebin with it, it kept the formatting there

https://pastebin.com/U4rGBS8Y

Great stuff, you get a Gold star

[Rich-Allen1976]

Well I copied/pasted the above code and it gives the following error.

 

[Beerkeg]

I did notice a mistake in my last pastebin, heres the new one https://pastebin.com/pWsMuWdk

also imgur link for what my output looks like https://imgur.com/a/kAPO1VJ

I think you're getting the error since you've only indented lines 7-9, but you need it for all of them. If my imgur link works, you can see what I did there. I don't really see anything else that would throw the error.

[Rich-Allen1976]

I did notice a mistake in my last pastebin, heres the new one https://pastebin.com/pWsMuWdk

also imgur link for what my output looks like https://imgur.com/a/kAPO1VJ

I think you're getting the error since you've only indented lines 7-9, but you need it for all of them. If my imgur link works, you can see what I did there. I don't really see anything else that would throw the error.

Thanks @Beerkeg, I appear to have sorted it, with the help of a guy on the Godot Community.

But thanks for trying your best to help

[Rich-Allen1976]

Code: Select all

 
extends KinematicBody2D

export var Speed:int
var velocity = Vector2()
var screensize = Vector2 (480, 720)
func get_input():
velocity = Vector2()
if Input.is_action_pressed ("ui_left"):
velocity.x -= 1
 if Input.is_action_pressed("ui_right"):
velocity.x += 1
if Input.is_action_pressed("ui_up"):
velocity.x -= 1
if Input.is_action_pressed("ui_down"):
velocity.x += 1
if velocity.length() > 0:
velocity = velocity.normalized() * Speed

Brings up an error, summat about the Area2D not being there.

HELP before I tear up the book and shove it somebody's arse.

[Beerkeg]

Okay, a few things...
1. Area2D and KinematicBody2D are not interchangeable, they're completely different classes for different purposes. So you can't just use the same bit of code for the other class.
2. What version of the godot engine are you using and what version is your book on? Several things change between versions, for example check out this doc https://docs.godotengine.org/en/stable/ ... -resources
3. Programming in high-level languages (like C#, GDscript and many others) sucks, because most of the time you're not programming, you're googling for methods and classes, syntax, because all the hard bits of code have been done for you. For example if your book tells you to use Area2D, but hasn't told you what it does, then you look it up, find godot's docs about it and read up on it. It'll tell you what parameters it has, it'll break down all the methods for you and it'll have code examples and tutorials. https://docs.godotengine.org/en/stable/ ... rea2d.html
Edit: Just noticed they also have example projects you can download where everything is already done and you can play around with the example to better understand what things do https://docs.godotengine.org/en/stable/ ... ea_2d.html (At the very bottom)

You don't learn to code from a book, you learn it by failing to get something to work again and again until you've learned from all your fails.

[Rich-Allen1976]

Okay, a few things...
1. Area2D and KinematicBody2D are not interchangeable, they're completely different classes for different purposes. So you can't just use the same bit of code for the other class.
2. What version of the godot engine are you using and what version is your book on? Several things change between versions, for example check out this doc https://docs.godotengine.org/en/stable/ ... -resources
3. Programming in high-level languages (like C#, GDscript and many others) sucks, because most of the time you're not programming, you're googling for methods and classes, syntax, because all the hard bits of code have been done for you. For example if your book tells you to use Area2D, but hasn't told you what it does, then you look it up, find godot's docs about it and read up on it. It'll tell you what parameters it has, it'll break down all the methods for you and it'll have code examples and tutorials. https://docs.godotengine.org/en/stable/ ... rea2d.html
Edit: Just noticed they also have example projects you can download where everything is already done and you can play around with the example to better understand what things do https://docs.godotengine.org/en/stable/ ... ea_2d.html (At the very bottom)

You don't learn to code from a book, you learn it by failing to get something to work again and again until you've learned from all your fails.

The book is for Godot 3, I'm using Godot 3.5.2.

Clearly the author's an idiot.